Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a tricky CI caching issue introduced by #1801
#1801 pulled in astonbitecode/j4rs#115 which fixes j4rs so that the build.rs script runs on the first build only, instead of on the first and second builds only. (it never ran on 3rd, 4th etc. builds)
However we are accidentally relying on this fact in our CI setup.
We build j4rs which sets up the target/debug/jassets directory.
The main branch CI run caches the
target
directory excluding jassets since its not a typical rust target file.On the next PR branch run CI restores
target
from the main branch cache such that j4rs is fully compiled (no build.rs to run) but the jassets directory is missing.Previously, since the build.rs would rerun on the 2nd rerun the jassets directory would be repopulated.
But that is no longer the case, and so the tests explode since jassets is missing.
To fix this issue, this PR adds the jassets directory to the rust-cache github actions config.
Its impossible to test this without merging since the main branch cache write only occurs after a PR is merged.
But it should fix it and if it doesnt fix the issue we'll just try something else.