Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix CI #1806

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Attempt to fix CI #1806

merged 2 commits into from
Nov 12, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented Nov 11, 2024

This PR fixes a tricky CI caching issue introduced by #1801

#1801 pulled in astonbitecode/j4rs#115 which fixes j4rs so that the build.rs script runs on the first build only, instead of on the first and second builds only. (it never ran on 3rd, 4th etc. builds)

However we are accidentally relying on this fact in our CI setup.
We build j4rs which sets up the target/debug/jassets directory.
The main branch CI run caches the target directory excluding jassets since its not a typical rust target file.
On the next PR branch run CI restores target from the main branch cache such that j4rs is fully compiled (no build.rs to run) but the jassets directory is missing.
Previously, since the build.rs would rerun on the 2nd rerun the jassets directory would be repopulated.
But that is no longer the case, and so the tests explode since jassets is missing.

To fix this issue, this PR adds the jassets directory to the rust-cache github actions config.
Its impossible to test this without merging since the main branch cache write only occurs after a PR is merged.
But it should fix it and if it doesnt fix the issue we'll just try something else.

Copy link

codspeed-hq bot commented Nov 11, 2024

CodSpeed Performance Report

Merging #1806 will not alter performance

Comparing rukai:ci_fix (480b0ac) with main (157f199)

Summary

✅ 38 untouched benchmarks

@rukai rukai merged commit ebe9484 into shotover:main Nov 12, 2024
41 checks passed
@rukai rukai mentioned this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants