Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI - Attempt #2 #1808

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Fix CI - Attempt #2 #1808

merged 1 commit into from
Nov 13, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented Nov 12, 2024

#1806 did not fix the issue, so this is attempt #2

As per the comment included in the CI change there is no way to properly fix this without upstream changes, so this PR provides an immediate workaround with the downside of increased CI time.
I am confident this will fix the issue this time since the PR passes without having to delete the cache.

Copy link

codspeed-hq bot commented Nov 12, 2024

CodSpeed Performance Report

Merging #1808 will not alter performance

Comparing rukai:fix_ci_attempt2 (6d21631) with main (f8a1570)

Summary

✅ 38 untouched benchmarks

@rukai rukai marked this pull request as ready for review November 12, 2024 06:15
@rukai rukai force-pushed the fix_ci_attempt2 branch 5 times, most recently from f797ffc to f11fdc9 Compare November 12, 2024 22:11
@rukai rukai merged commit ffcaf93 into shotover:main Nov 13, 2024
41 checks passed
@rukai rukai mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants