Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add an entry for zip_fix engine #277

Merged
merged 2 commits into from
Apr 12, 2023
Merged

chore: Add an entry for zip_fix engine #277

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3e77f0
Add an entry for zip_fix engine
eseidel Apr 11, 2023
80f1787
remove unused shorebirdStorageBucket
felangel Apr 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/artifact_proxy/lib/config.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ const config = ProxyConfig(
class _EngineMapping3_7 extends EngineMapping {
const _EngineMapping3_7({
required super.flutterEngineRevision,
// https://github.com/dart-lang/sdk/issues/52016
// ignore: unused_element
super.shorebirdStorageBucket = 'download.shorebird.dev',
}) : super(
shorebirdArtifactOverrides: const {
Expand Down Expand Up @@ -43,8 +45,8 @@ class _EngineMapping3_7 extends EngineMapping {
/// Flutter 3.7.10
const flutter_3_7_10 = {
// Attempt to fix https://github.com/shorebirdtech/shorebird/issues/235
'f68335f3f6afdb1595420b1c3b5a16c8da75a1cf': _EngineMapping3_7(
shorebirdStorageBucket: 'download-dev.shorebird.dev',
'adb70a20d4718b5ce60cdd99ad81d8de54afcb35': _EngineMapping3_7(
// shorebirdStorageBucket: 'download-dev.shorebird.dev',
Copy link
Contributor

@felangel felangel Apr 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want this using the prod bucket?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already pushed in prod:
https://console.cloud.google.com/storage/browser/download.shorebird.dev/shorebird/adb70a20d4718b5ce60cdd99ad81d8de54afcb35?pageState=(%22StorageObjectListTable%22:(%22f%22:%22%255B%255D%22))&project=code-push-prod&prefix=&forceOnObjectsSortingFiltering=false

But I guess I could push it again, this time to dev. 🤷

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you just wanted to make sure this was intentional

flutterEngineRevision: 'ec975089acb540fc60752606a3d3ba809dd1528b',
),
'978a56f2d97f9ce24a2b6bc22c9bbceaaba0343c': _EngineMapping3_7(
Expand Down