chore: Add an entry for zip_fix engine #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseidel
changed the title
felangel
reviewed
Apr 11, 2023
| 'f68335f3f6afdb1595420b1c3b5a16c8da75a1cf': _EngineMapping3_7( | ||
| shorebirdStorageBucket: 'download-dev.shorebird.dev', | ||
| 'adb70a20d4718b5ce60cdd99ad81d8de54afcb35': _EngineMapping3_7( | ||
| // shorebirdStorageBucket: 'download-dev.shorebird.dev', |
There was a problem hiding this comment.
You want this using the prod bucket?
There was a problem hiding this comment.
It's already pushed in prod:
https://console.cloud.google.com/storage/browser/download.shorebird.dev/shorebird/adb70a20d4718b5ce60cdd99ad81d8de54afcb35?pageState=(%22StorageObjectListTable%22:(%22f%22:%22%255B%255D%22))&project=code-push-prod&prefix=&forceOnObjectsSortingFiltering=false
But I guess I could push it again, this time to dev. 🤷
There was a problem hiding this comment.
Up to you just wanted to make sure this was intentional
felangel
approved these changes
Apr 11, 2023
That's working around dart-lang/sdk#52016 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an entry to artifact_proxy for my in-progress fix to the engine:
https://github.com/shorebirdtech/engine/tree/zip_fix