-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][ADD] shopinvader_api_sale_loyalty: FastAPI services to apply coupons #1430
[16.0][ADD] shopinvader_api_sale_loyalty: FastAPI services to apply coupons #1430
Conversation
3c6d596
to
09f925a
Compare
shopinvader_api_sale_loyalty/models/shopinvader_api_cart_service_helper.py
Outdated
Show resolved
Hide resolved
94ab4b8
to
560b584
Compare
This module will maybe need some schemas adaptations when #1421 will be finished but it's ready for first reviews. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marielejeune The code is clear and easy to read! A few comments to make it even better.
560b584
to
e50c9a0
Compare
a1bf7e8
to
81b5e36
Compare
@marielejeune ciao, any plan to finish this? |
Hi @simahawk , this is finished and waiting for reviews :-) Feel free also to have a look at the dependent PR in OCA/sale-workflow |
81b5e36
to
7288c6f
Compare
CHANGES (following the logic in #1495)
|
7288c6f
to
89fb7d2
Compare
I've cherry-picked your commit |
@marielejeune All your dev dependencies are now merged... can you cleanup the test-requirements plz? |
35981a7
to
69caba6
Compare
Keep a more natural behavior. Preserve the old routes, but set them as deprecated
Use sudo when running the wizard to avoid having to provide any sort of ACL and RR to related records.
69caba6
to
39c4f27
Compare
I've also added the |
/ocabot merge path |
Hi @lmignon. Your command failed:
Ocabot commands
More information
|
/ocabot merge patch |
Hey, thanks for contributing! Proceeding to merge this for you. |
It looks like something changed on |
It looks like something changed on |
Congratulations, your PR was merged at b64c0ca. Thanks a lot for contributing to shopinvader. ❤️ |
FastAPI services for applying coupons to cart.
Depends on
TODO
/apply_coupon
service must be oncart
router, notloyalty
router/apply_reward
to apply a claimable reward (automatic program, without code)CartResponse
must return all claimable rewards, so that before validating the cart, if some rewards are still claimable, they can be applied (by calling the/apply_reward
service, chosing the right reward / free product).shopinvader_cart_user_group
must have theshopinvader_loyalty_user_group
as it uses all loyalties concepts.reward_amount
andreward_amount_tax_included
.