[16.0] [ADD] sale_loyalty_order_info: New module #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marielejeune
changed the title
5 tasks
chienandalu
reviewed
Nov 13, 2023
There was a problem hiding this comment.
Thanks @marielejeune !
Some questions about the implemation:
marielejeune
force-pushed
the
16.0-add-sale_loyalty_order_info-mle
branch
from
1b36103 to
cd6ed8c
Compare
chienandalu
reviewed
Dec 21, 2023
These fields are added for reporting purposes. One can add them in views if needed, but I didn't to avoid triggering computations (computed non stored fields). |
|
Ok, a note in the readme describing the current module purpose would be enough 🙂 |
marielejeune
force-pushed
the
16.0-add-sale_loyalty_order_info-mle
branch
from
cd6ed8c to
13e3897
Compare
Done! |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at ad01676. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module provides more info on the applied loyalty rewards on a sale order.
It provides: