Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating RTMP onMetaData based on input data. #1304

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Creating RTMP onMetaData based on input data. #1304

merged 1 commit into from
Sep 26, 2023

Conversation

shogo4405
Copy link
Owner

Description & motivation

  • The creation condition for onMetaData was originally based on the presence of a device attachment, but it has been switched to the presence of a signal. This change allows sending metadata as expected without the need to inherit RTMPStream, even with APIs like ReplayKit or ScreenCaptureKit.
  • Fix metadata not coming through when sending sampleBuffers #1074

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots:

@shogo4405 shogo4405 added this to the 1.7.0 milestone Sep 26, 2023
@shogo4405 shogo4405 merged commit 7c94fbb into main Sep 26, 2023
1 check failed
@shogo4405 shogo4405 deleted the feature/metada branch September 26, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
1 participant
@shogo4405