Fix metadata not coming through when sending sampleBuffers

[charmingtoad]

Description & motivation

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots:

[charmingtoad]

I had the same issue as #892 and fixed it with this.

[shogo4405]

This is not good. This code will send video and audio metadata always. I don't want send.

[shogo4405]

Please override RTMPStream.

class YourRTMPStream: RTMPStream {
    override func createMetadata() -> ASObject  {
           ...
    }
}

[charmingtoad]

I see, I didn't think of the case that a user might want to only send video or audio but not both.
I made a new class where user can set flags to specify what kind of sampleBuffer they intend to send.
Hope this is okay, let me know if more changes are needed. Thanks!

[shogo4405]

No problem. Just as I thought 👍 I think this PR is good for an example application
This PR is not generic. Please consider to use your application code. Thank you.

[charmingtoad]

Ah, I have the issue that I can't use this in my application code because mixer.videoIO and mixer.audioIO have 'internal' protection level, so my app cannot access them. Is there any way to send metadata for apps that use the appendSampleBuffer method?

[shogo4405]

You can access videoSetting or audioSetting properties.

• Private
  • metadata["width"] = mixer.videoIO.codec.width
  • metadata[“height”] = mixer.videoIO.codec.height
  • metadata["audiobitrate"] = mixer.audioIO.codec.bitrate
• Public
  • metadata["width"] = videoSetting[“width”]
  • metadata["height"] = videoSetting["height"]
  • metadata["audiobitrate"] = audioSetting["bitrate"]

[charmingtoad]

ああ、これで分かった。教えてくれてどうもありがとうございます。このPRを閉めます。