Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/type consolidation #75

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Mar 5, 2024

Closes #74

Closes #22

Part of #72

This PR renames and consolidates many API contract types, to make it more consistent, and adhere to the changes from Shlink 4.0.0.

It also drops supports for Shlink older than v3.3.0, removing the need to take the API v2 into consideration.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 65.33333% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 77.07%. Comparing base (a1bf79e) to head (2f19dd3).
Report is 8 commits behind head on main.

Files Patch % Lines
src/api/ShlinkApiClient.ts 64.86% 0 Missing and 26 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   85.71%   77.07%   -8.65%     
==========================================
  Files          13        9       -4     
  Lines         763      410     -353     
  Branches      103       92      -11     
==========================================
- Hits          654      316     -338     
+ Misses          7        3       -4     
+ Partials      102       91      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit ec16d59 into shlinkio:main Mar 5, 2024
5 of 7 checks passed
@acelaya acelaya deleted the feature/type-consolidation branch March 5, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for Shlink older than 3.3.0 Improve, organize and consolidate API contract types
1 participant