Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Shlink older than 3.3.0 #74

Closed
acelaya opened this issue Mar 5, 2024 · 0 comments · Fixed by #75
Closed

Drop support for Shlink older than 3.3.0 #74

acelaya opened this issue Mar 5, 2024 · 0 comments · Fixed by #75
Labels
enhancement
Milestone
1.0.0

Comments

@acelaya
Copy link
Member

acelaya commented Mar 5, 2024

This is the version that introduced the API v3. Dropping support for older versions means there's no longer a need to fall back to v2 when Shlink returns a 404 error.

It also means the ErrorTypeV2 enum can be completely dropped, and rename ErrorTypeV3 to simply ErrorType.
@acelaya acelaya added this to Shlink Mar 5, 2024
@acelaya acelaya added this to the 1.0.0 milestone Mar 5, 2024
@acelaya acelaya moved this to In Progress in Shlink Mar 5, 2024
@acelaya acelaya moved this from In Progress to In review in Shlink Mar 5, 2024
@acelaya acelaya mentioned this issue Mar 5, 2024
Merged
@github-project-automation github-project-automation bot moved this from In review to Done in Shlink Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
Shlink
Archived in project
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Feature/type consolidation acelaya-forks/shlink-js-sdk
1 participant
@acelaya