Fixed underlining when no explicit foreground color is set #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made `color` optional when creating an underline element. In addition, if the `underlineColor` attribute is present, it will be preferred over `foregroundColor` (if any). If neither is specified, the underline color will not be output explicitly.
… an underline When no underline color is explicitly specified on the <w:u> element, Word already falls back to the text color. So, there’s no reason for DocX to perform this check as well.
shinjukunian
approved these changes
Jan 27, 2023
|
Thank you fro your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
colorargument tounderlineElementis now optional, since the OOXML<w:u>element doesn't require it. If theunderlineColorNSAttributedString.Key is set, that will be passed. Otherwise, when nil is passed, no color will be explicitly set. Happily, in that case, Word just uses the text color anyways.