Underlining doesn't work when color isn't also specified

[andalman]

If you have an attributed string and apply NSAttributedString.Key.underlineStyle to it, the generated docx will not include that underline. This is because DocX requires that foregroundColor must be set, otherwise the <w:u> element won't be output.

Since the w:color value is optional in the docx, I don't think this should be required. I have a fix ready that makes the color argument Optional in the underlineElement function.

That said, I'm not sure using the foregroundColor is correct either, since NSAttributedString.Key.underlineColor exists for the purpose. If existing code relies on this behavior, though, we could have DocX check for the underlineColor and, if that isn't found, then use the foregroundColor if it exists. Thoughts?

[shinjukunian]

Hi
thank you for catching this. It seems my original implementation of underlines was a bit lackadaisical. I guess I was not aware that the color was optional for the <w:u> element.
I agree with your second suggestion - drop the requirement for a backgroundcolor and use NSAttributedString.Key. underlineColor for user-specified colors. We should test if the fallback to foregroundColor is required in DocX or if Word does this automatically.

[andalman]

I just tested, and it appears that Word does fall back to the text’s color when no color is explicitly set on the <w:u> element. I’ll submit a pull request for a change that looks for underlineColor only, then.

…

On Jan 26, 2023 at 01:39:21, Morten ***@***.***> wrote: Hi thank you for catching this. It seems my original implementation of underlines was a bit lackadaisical. I guess I was not aware that the color was optional for the <w:u> element. I agree with your second suggestion - drop the requirement for a backgroundcolor and use NSAttributedString.Key. underlineColor for user-specified colors. We should test if the fallback to foregroundColor is required in DocX or if Word does this automatically. — Reply to this email directly, view it on GitHub <#36 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADXE3PWVYAWJZFZVL456MODWUJA4TANCNFSM6AAAAAAUGZ3UEU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[shinjukunian]

Fixed in #37 . Thank you for addressing this!