feat(paralell): enable parallel tests generating an unique database name per test file, fix #206 #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame per test file, fix shelfio#206
This was referenced Jun 8, 2020
randomhash
reviewed
Jun 9, 2020
randomhash
reviewed
Jun 9, 2020
|
I've fixed to handle both same feel free to merge and improve from here |
vladholubiev
changed the title
|
@sibelius great job! thank you ;) |
randomhash
approved these changes
Jun 9, 2020
vladholubiev
reviewed
Jun 9, 2020
| @@ -56,7 +55,8 @@ | |||
| "prettier": "2.0.5" | |||
| }, | |||
| "peerDependencies": { | |||
| "mongodb": "3.x.x" | |||
| "mongodb": "3.x.x", | |||
| "mongodb-memory-server": "*" | |||
There was a problem hiding this comment.
What was the reason of moving this out to peerDependencies? I'm ok with that as long as there is a reason and this is documented in READMe.
There was a problem hiding this comment.
so we can use any version of mongodb-memory-server
|
@vladgolubev when is the plan to merge this PR? |
|
Today) |
Closed
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
path.join(cwd)is more stable then__dirnamewhen running inside a monorepo