-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add worker build on CI #7637
base: main
Are you sure you want to change the base?
Conversation
|
7aa7645
to
271e493
Compare
Circle has node 11.8 now, which has the |
We test threads but we're actually running our test suite serially. Maybe it's worth to run tests by default on 2 or 4 workers and run in band e.g. on travis or somewhere? |
haha, it just died 😛 But looking at, and fixing, |
Test failures on node 12, that's odd... |
Very interesting - tests fail on circus, but passes on GH Actions. The failing test on CI passes on my local machine. Very odd... |
jest.config.ci.js
Outdated
'jest-silent-reporter', | ||
{showPaths: true, showWarnings: true, useDots: true}, | ||
], | ||
'default', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
heh, soz. At the time it was useful to get test timings and such, now that we're down to actual test failures it should be good to move back 😉
for those that want to test this, check this patch-package https://gist.github.com/sibelius/c6ef3f0890814dd4163a9ada0cd739f1 |
@sibelius very interested in hearing numbers if you play with - does it impact memory/cpu usage? |
I've tried to use worker_threads because child process was failing for us, here is the issue #10144 When using
137 means Out of Memory. So worker threads is kind of worse than child process right now for us mongodb-memory-server was causing OOM for us because it was spinning 1 mongod per test file, we fixed this here shelfio/jest-mongodb#209 but worker_threads still leaking on CircleCI but it does not leak when running local, |
we fixed most issues of our tests and now worker_threads is working fine for us (node 12.18.0) we didn't notice any improvement in cpu time or memory usage |
https://www.npmjs.com/package/piscina just leaving this here as something to maybe explore in the future, who knows, maybe it's faster than |
what is missing here? |
how can I enable worker threads on jest config ? |
Summary
From #7610. @rickhanlonii could you take a look? 🙂
Test plan
Will fail (for now)