Explicitly set charset to UTF-8 when loading local scripts #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shd101wyy
approved these changes
Jun 25, 2018
|
But TravisCI build failed. |
This prevents minified vega to throw an exception around a regexp, which becomes corrupt if a different encoding is used. The error was taking place in VSCode.
kachkaev
force-pushed
the
local-scripts-utf8
branch
from
d31f70a to
6daaa44
Compare
|
Many thanks for your review @shd101wyy! The build was failing because of a breaking change in TS 2.9 (microsoft/TypeScript#24628). I addressed this in a6de16e and then rebased this PR on top of the latest master. Now the CI passes, so I merge 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents minified vega to throw an exception around a regexp, which becomes corrupt if a different encoding is used. The error was taking place in VSCode.
The reasons why this PR fails checks are addressed in #76. I'll rebase this commit once that PR lands master. @shd101wyy WDYT in general?