Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfill XMLHttpRequest and reflect dependency updates #76

Merged
merged 4 commits into from
Jun 25, 2018

Conversation

kachkaev
Copy link
Collaborator

@kachkaev kachkaev commented Jun 23, 2018

Polyfill XMLHttpRequest to load vega data from remote URLs in Node env

Also limit TypeScript to 2.8 because of this problem in 2.9: microsoft/TypeScript#24628 (should be fixed in TS 3.0)

Reformat a few files to reflect changes in prettier 1.13

@kachkaev kachkaev changed the title Polyfill xmlhttprequest Polyfill XMLHttpRequest Jun 23, 2018
@kachkaev kachkaev requested a review from shd101wyy June 23, 2018 15:57
@kachkaev kachkaev changed the title Polyfill XMLHttpRequest Polyfill XMLHttpRequest and reflect dependency updates Jun 23, 2018
Copy link
Owner

@shd101wyy shd101wyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks a lot!

@kachkaev kachkaev merged commit 877f02f into master Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants