(index.lisp) add-indexes: Ensure (safety 3) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about wrapping the body with |
|
It does, I'll update the PR |
Although modifying &REST lambda variables is not strictly forbidden by the CLHS, it is discouraged[1]. When compiling under safety values less than 3 SBCL assumes the &REST parameter to be a list, so calls to elt are specialized to the list variation. Rebind the rest parameter to itself as a workaround. [1]: "There is a particular problem with &REST lambda variables, which are always bound to a value of type LIST." cf. http://www.lispworks.com/documentation/HyperSpec/Issues/iss178_w.htm
|
With this PR, #7 and #8 the test suite passes on SBCL. It still fails on CCL and on ABCL though. the ABCL failures seem related to this commit |
|
Cool, thanks. Merged the three PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although modifying &REST lambda variables is not strictly forbidden by
the CLHS, it is discouraged[1]. When compiling under safety values less
than 3 SBCL assumes the &REST parameter to be a list, so calls to elt are
specialized to the list variation.
[1]: "There is a particular problem with &REST lambda variables, which
are always bound to a value of type LIST."
cf. http://www.lispworks.com/documentation/HyperSpec/Issues/iss178_w.htm
A better solution in the long term would be to rewrite add-indexes