Fix standard analyzer tests #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assertions 8-12 from TEST-STANDARD-ANALYZER were failing because by default STANDARD-ANALYZER skips the words in *ENGLISH-STOP-WORDS*. Also add two more tests to test that this behaviour is customizable by passing a different list of stop words to the standard-analyzer
PuercoPop
force-pushed
the
standard-analyzer-tests
branch
from
24894f9 to
6b83e23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assertions 8-12 from TEST-STANDARD-ANALYZER were failing because by
default STANDARD-ANALYZER skips the words in ENGLISH-STOP-WORDS. I'm guessing the tests weren't updated to reflect the functionality.
Also add two more tests to test that this behaviour is customizable by
passing a different list of stop words to the standard-analyzer
I also added some docstrings (in a separate commit if they are deemed inappropriate)
cf. #6