fix: use correct account id for matching buy account #6263
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not use the
sellAssetAccountId
for derivingbuyAccountId
, but instead derivemaybeMatchingBuyAccountId
using the same account number as the sell asset. This ensures we use the correct matchingaccountId
for the buy asset and are able to generate a receive address and subsequently trade quotes.Regression: #6229
Follow up issue: #6262
Pull Request Type
Issue (if applicable)
N/A - prod issue
Risk
Medium - logic changes what buy account is used for the trade
All trades
Testing
Engineering
☝️
Operations
☝️
Screenshots (if applicable)