Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select to account disabled in swapper when no valid quotes are present #6262

Closed
0xean opened this issue Feb 20, 2024 · 0 comments · Fixed by #6355
Closed

Select to account disabled in swapper when no valid quotes are present #6262

0xean opened this issue Feb 20, 2024 · 0 comments · Fixed by #6355
Assignees
@0xApotheosis
Labels
bug Something isn't working

Comments

@0xean
Copy link
Contributor

0xean commented Feb 20, 2024

Screenshot 2024-02-20 at 1 26 34 PM

Currently when you have no valid quotes available in the swapper you cannot correctly select a "To" account from the dropdown (its disabled).

To repro on demo wallet

  1. select ETH to BTC
  2. Click BTC balance to show accounts, see that the selection is disabled

Expected state:

User can select a valid to account before valid quotes are shown.
@0xean 0xean added the bug Something isn't working label Feb 20, 2024
@kaladinlight kaladinlight mentioned this issue Feb 20, 2024
Merged
3 tasks
@0xApotheosis 0xApotheosis self-assigned this Mar 5, 2024
@0xApotheosis 0xApotheosis moved this from To schedule to Up next in ShapeShift Dashboard Mar 5, 2024
@0xApotheosis 0xApotheosis moved this from Up next to In progress in ShapeShift Dashboard Mar 5, 2024
@0xApotheosis 0xApotheosis mentioned this issue Mar 5, 2024
Merged
3 tasks
@0xApotheosis 0xApotheosis moved this from In progress to In review in ShapeShift Dashboard Mar 5, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in ShapeShift Dashboard Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xApotheosis 0xApotheosis

Labels
bug Something isn't working
Projects
ShapeShift Dashboard
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: always allow account selection shapeshift/web
2 participants
@0xean @0xApotheosis