Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot generation with plot=False #168

Closed
VolkiTheDreamer opened this issue Jan 5, 2025 · 3 comments · Fixed by #169
Closed

Plot generation with plot=False #168

VolkiTheDreamer opened this issue Jan 5, 2025 · 3 comments · Fixed by #169
Labels
bug Something isn't working

Comments

@VolkiTheDreamer
Copy link

Version check:

Run and copy the output:

import sys, dython
print(sys.version_info)
print(dython.__version__)

sys.version_info(major=3, minor=10, micro=12, releaselevel='final', serial=0)
0.7.8

i am on colab by the way.

Describe the bug:

even though i pass False to plot parameter it generates the plot.
Code to reproduce:

import dython
corrdict=associations(df,nominal_columns=cats,numerical_columns=nums,plot=False)
@VolkiTheDreamer VolkiTheDreamer added the bug Something isn't working label Jan 5, 2025
shakedzy added a commit that referenced this issue Jan 6, 2025
@shakedzy shakedzy linked a pull request Jan 6, 2025 that will close this issue
shakedzy added a commit that referenced this issue Jan 6, 2025
…-in-a-notebook-and-plot=false-the-plot-gets-closed-ie-removed-without-ever-being-shown

fix for #167 #168
@shakedzy
Copy link
Owner

shakedzy commented Jan 6, 2025

Fix available on the new 0.7.9

@VolkiTheDreamer
Copy link
Author

Fix available on the new 0.7.9
Screenshot from 2025-01-12 21-56-19

Well, not sure it is fixed. i reinstalled it on colab and it still generates the plot

@VolkiTheDreamer
Copy link
Author

I think i realized the problem now. i should pass the "compute_only=True", not to fiddle with plot parameter. Now it's ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants