When using the associations in a notebook and plot=False, the plot gets closed (i.e. removed) without ever being shown.

[Baukebrenninkmeijer]

Hi, thank you for your work on this library.

Version check:

sys.version_info(major=3, minor=12, micro=5, releaselevel='final', serial=0)
0.7.7

However, this problem is still present in 0.7.8.

Describe the bug:

When calling nominal.associations with plot=False when using a notebook and passing an axis, the plot gets closed. What I expect to happen here is that the plot is not closed, the chart is added to the axis and then I can control what happens to it afterwards. Currently, the plots gets closed before that is possible.

Code to reproduce:

from dython.nominal import associations
df = pd.read_csv('fake_test_sample.csv')
fig, ax = plt.subplots(1, 2, figsize=(20, 8))

  fake_corr = associations(
      fake,
      nominal_columns=fake.select_dtypes(['object', 'category']),
      plot=False,
      nom_nom_assoc='theil',
      mark_columns=True,
      annot=annot,
      ax=ax[1],
      cmap=cmap,
  )['corr']
plt.show(). # This is currently empty, rather than having one plot on it.

Error message:

Error message:

<Figure size 640x480 with 0 Axes>

Input data:

real_test_sample.csv
fake_test_sample.csv

Though this issue will persist regardless of what data is used.

[shakedzy]

Seems to be an issue with how #147 was handled.. I'll have to come up with something else

[shakedzy]

Fix available on the new 0.7.9