test: remove packageManager from dummy app
#383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
G-Rath
changed the title
packageManager from dummy app
ahangarha
approved these changes
Nov 24, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Yarn v1.22.20 introduced a check to ensure that the right version of Yarn was actually being used, which breaks the specs because while the dummy app specifies it should be using Yarn v3 in it's
package.json, Yarn Berry is not properly setup so it'll never get used.Removing
packageManagerresolves this.Pull Request checklist
Add/update test to cover these changesUpdate documentationUpdate CHANGELOG file