Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emit a deprecation warning for https and don't mention it in generated config #382

Merged
merged 2 commits into from
Dec 7, 2023
Merged

fix: emit a deprecation warning for https and don't mention it in generated config #382

merged 2 commits into from
Dec 7, 2023

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Nov 23, 2023

Summary

If this flag is deprecated then it shouldn't be mentioned in the generated config because that just encourages its usage; we should also be omitting a deprecation warning so people know to move off it

Pull Request checklist

  • Add/update test to cover these changes
  • Update documentation
  • Update CHANGELOG file

@G-Rath
Copy link
Contributor Author

G-Rath commented Nov 23, 2023

CI is currently failing because of a recent Yarn v1.22.21 change which it sounds like is causing general problems - I've not seen any evidence that it actually breaks standard projects (i.e. CIs for package_json and rails-template are still passing across all package managers), and I think this can be fixed here by just adding SKIP_YARN_COREPACK_CHECK to CI but I'm going to do some debugging via #383 first

#383 fixes CI

Copy link
Contributor

@ahangarha ahangarha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine to me. If this is deprecated in webpack, then we should also deprecate its equivalent in Shakapacker.

Copy link
Member

@justin808 justin808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Please fix changelog conflict and merge.

@Judahmeek Judahmeek merged commit 90c93ff into shakacode:master Dec 7, 2023
41 checks passed
@G-Rath G-Rath deleted the improve-deprecation branch December 7, 2023 23:21
Eric-Guo added a commit to thape-cn/pp that referenced this pull request Jan 2, 2024
Eric-Guo added a commit to Eric-Guo/tailwindcss-jit-stimulus that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants