Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run tests in Docker #5440

Merged
merged 3 commits into from
Aug 8, 2023
Merged

ci: run tests in Docker #5440

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8052f5
run tests in docker
tykus160 Jul 26, 2023
9e8f8ad
make test as a last step build_in_docker job
tykus160 Jul 26, 2023
4d00385
revert build-and-test.yaml
tykus160 Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions build/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,17 @@
# docker build -t shaka-player-build /path/to/shaka-player/build/docker
# Run with:
# docker run -v /path/to/shaka-player:/usr/src --user $(id -u):$(id -g) shaka-player-build
# Run tests with:
# docker run -v /path/to/shaka-player:/usr/src --user $(id -u):$(id -g) shaka-player-build python3 build/test.py --quick --browsers ChromeHeadless
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove --quick, and switch --browsers ChromeHeadless to --browsers Chrome --use-xvfb. Headless testing is problematic for a video player, but using xvfb allows playback and screenshot tests to proceed.


FROM alpine:3.14
FROM alpine:3.18

# Install dependencies
RUN apk add --update --no-cache \
bash git nodejs npm openjdk11-jre-headless python3
bash chromium chromium-chromedriver git nodejs npm openjdk11-jre-headless python3
joeyparrish marked this conversation as resolved.
Show resolved Hide resolved

WORKDIR /usr/src
ENV HOME /tmp
ENV CHROMEDRIVER_PATH /usr/bin/chromedriver
joeyparrish marked this conversation as resolved.
Show resolved Hide resolved

CMD ["python3", "build/all.py"]