ci: run tests in Docker #5440
Merged
ci: run tests in Docker #5440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incremental code coverage: No instrumented code was changed. |
joeyparrish
requested changes
Aug 7, 2023
| @@ -2,14 +2,17 @@ | |||
| # docker build -t shaka-player-build /path/to/shaka-player/build/docker | |||
| # Run with: | |||
| # docker run -v /path/to/shaka-player:/usr/src --user $(id -u):$(id -g) shaka-player-build | |||
| # Run tests with: | |||
| # docker run -v /path/to/shaka-player:/usr/src --user $(id -u):$(id -g) shaka-player-build python3 build/test.py --quick --browsers ChromeHeadless | |||
There was a problem hiding this comment.
Please remove --quick, and switch --browsers ChromeHeadless to --browsers Chrome --use-xvfb. Headless testing is problematic for a video player, but using xvfb allows playback and screenshot tests to proceed.
joeyparrish
approved these changes
Aug 8, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Aug 19, 2023
This PR adds Chromium with webdriver to the Docker image, so it's now possible to run at least some subset of tests using Docker env. Additionally, Alpine version has been bumped up, so recent version of Chromium can be used.
joeyparrish
pushed a commit
that referenced
this pull request
Aug 20, 2023
This PR adds Chromium with webdriver to the Docker image, so it's now possible to run at least some subset of tests using Docker env. Additionally, Alpine version has been bumped up, so recent version of Chromium can be used.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Chromium with webdriver to the Docker image, so it's now possible to run at least some subset of tests using Docker env.
Additionally, Alpine version has been bumped up, so recent version of Chromium can be used.