fix: Fix captions from MP4s with multiple trun boxes #5422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Incremental code coverage: 88.24% |
|
I initially omitted two binary files from the PR, but that has been fixed and tests should pass now in CI (as they do here locally). |
|
Failure in Safari-old seems unrelated |
theodab
approved these changes
Jul 20, 2023
joeyparrish
added a commit
that referenced
this pull request
Jul 20, 2023
joeyparrish
added a commit
that referenced
this pull request
Jul 20, 2023
Backported to v4.2.x Closes #5328
joeyparrish
added a commit
to joeyparrish/shaka-player
that referenced
this pull request
Jul 21, 2023
Tizen 3 does not support Array.flat(). This fixes a runtime exception on Tizen 3 by replacing flat() with concat() and the spread operator. This also bans the use of flat(). flat() was originally introduced in PR shaka-project#5422
joeyparrish
added a commit
that referenced
this pull request
Jul 21, 2023
Tizen 3 does not support Array.flat(). This fixes a runtime exception on Tizen 3 by replacing flat() with concat() and the spread operator. This also bans the use of flat(). flat() was originally introduced in PR #5422
joeyparrish
added a commit
that referenced
this pull request
Jul 21, 2023
Tizen 3 does not support Array.flat(). This fixes a runtime exception on Tizen 3 by replacing flat() with concat() and the spread operator. This also bans the use of flat(). flat() was originally introduced in PR #5422
joeyparrish
added a commit
that referenced
this pull request
Jul 21, 2023
Tizen 3 does not support Array.flat(). This fixes a runtime exception on Tizen 3 by replacing flat() with concat() and the spread operator. This also bans the use of flat(). flat() was originally introduced in PR #5422
|
Could be this related to #5416? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5328