-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MP4 CEA parser does not know that there could be multiple TRUN boxes #5328
Comments
Info from https://thumb.co.il/ |
Ah, I see. So if there are multiple truns, that means multiple mdats, too, correct? That shouldn't be too difficult to fix. |
I was wrong. One segment I'm analyzing has, for example:
So per moof, there are two trun boxes and one mdat. So parsing needs to reset on every moof, and I need to understand how to interpret the extra trun box. It looks like the samples need to be combined. |
This suggests that the samples from both trun boxes need to be processed: https://bugzilla.mozilla.org/show_bug.cgi?id=1143491 |
Backported to v4.2.x Closes #5328
Have you read the FAQ and checked for duplicate open issues? YES
What version of Shaka Player are you using? Main branch
Can you reproduce the issue with our latest release version? Yes
Can you reproduce the issue with the latest code from
main
? YesAre you using the demo app or your own custom app? Demo
If custom app, can you reproduce the issue using our demo app? Yes
What browser and OS are you using?
Chrome, macOS
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?
https://d2zihajmogu5jn.cloudfront.net/advanced-fmp4/master.m3u8
What configuration are you using? What is the output of
player.getConfiguration()
?Default
What did you do?
Load the previous stream and enable the CC
What did you expect to happen?
CC are shown correctly
What actually happened?
Only
bop!
is shown.bip!
is not displayed.The problem is that the analyzer assumes that there is only one box trun, and that is not true, in this case there are 2 TRUN boxes, See: https://github.com/shaka-project/shaka-player/blob/main/lib/cea/mp4_cea_parser.js#L180
The text was updated successfully, but these errors were encountered: