Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Document Picture-in-Picture: Use width/height instead of initialAspectRatio #5224

Merged
merged 1 commit into from
May 11, 2023
Merged

fix: Document Picture-in-Picture: Use width/height instead of initialAspectRatio #5224

merged 1 commit into from
May 11, 2023

Conversation

beaufortfrancois
Copy link
Contributor

The initialAspectRatio option was removed from the Document Picture-in-Picture spec in favour of width and height, so we should use them. See WICG/document-picture-in-picture#36

@beaufortfrancois beaufortfrancois changed the title Document Picture-in-Picture: Use width/height instead of initialAspectRatio fix: Use width/height instead of initialAspectRatio for pip May 11, 2023
@avelad avelad changed the title fix: Use width/height instead of initialAspectRatio for pip fix: Document Picture-in-Picture: Use width/height instead of initialAspectRatio May 11, 2023
@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels May 11, 2023
@avelad avelad added this to the v4.4 milestone May 11, 2023
@avelad avelad requested review from avelad and theodab May 11, 2023 09:03
@github-actions
Copy link
Contributor

Incremental code coverage: 0.00%

@avelad avelad merged commit 0da63a0 into shaka-project:main May 11, 2023
@github-actions github-actions bot mentioned this pull request May 11, 2023
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

@avelad avelad avelad approved these changes

Assignees
No one assigned
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@beaufortfrancois @avelad @theodab