fix: Document Picture-in-Picture: Use width/height instead of initial…

…AspectRatio (#5224) The `initialAspectRatio` option was removed from the Document Picture-in-Picture spec in favour of `width` and `height`, so we should use them. See WICG/document-picture-in-picture#36
shaka-project · May 11, 2023 · 0da63a0 · 0da63a0
1 parent 1c89204
commit 0da63a0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/externs/pictureinpicture.js b/externs/pictureinpicture.js
@@ -53,7 +53,6 @@ HTMLMediaElement.prototype.webkitPresentationMode;
 
 /**
  * @typedef {{
- *   initialAspectRatio: (number|undefined),
  *   width: (number|undefined),
  *   height: (number|undefined),
  *   copyStyleSheets: (boolean|undefined),

diff --git a/ui/pip_button.js b/ui/pip_button.js
@@ -162,7 +162,8 @@ shaka.ui.PipButton = class extends shaka.ui.Element {
     const pipPlayer = this.videoContainer_;
     const rectPipPlayer = pipPlayer.getBoundingClientRect();
     const pipWindow = await window.documentPictureInPicture.requestWindow({
-      initialAspectRatio: rectPipPlayer.width / rectPipPlayer.height,
+      width: rectPipPlayer.width,
+      height: rectPipPlayer.height,
       copyStyleSheets: true,
     });