Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Fix iOS fullscreen on rotation #4679

Merged
merged 6 commits into from
Dec 6, 2022
Merged

fix(ui): Fix iOS fullscreen on rotation #4679

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0d32b0d
fix(ui): check requestFullscreen function when screen rotation event …
ocipap Nov 10, 2022
95c012f
fix(ui): fixed to allow fullscreen on iOS
ocipap Nov 11, 2022
1e328a1
fix(ui): remove console log
ocipap Nov 11, 2022
888c6bf
refactor: Unnecessary code removal and refectoring
ocipap Nov 15, 2022
de5e0ff
refactor: remove three nested try/catch blocks
ocipap Nov 21, 2022
2dc32cf
Fix error-handling comment
joeyparrish Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ui/controls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1025,7 +1025,9 @@ shaka.ui.Controls = class extends shaka.util.FakeEventTarget {
this.video_.readyState == 0 ||
this.castProxy_.isCasting() ||
!this.config_.enableFullscreenOnRotation ||
!this.isFullScreenSupported()) {
!this.isFullScreenSupported()||
typeof (this.video_.requestFullscreen) !== 'function'
joeyparrish marked this conversation as resolved.
Show resolved Hide resolved
) {
joeyparrish marked this conversation as resolved.
Show resolved Hide resolved
return;
}

Expand Down