fix(ui): Fix iOS fullscreen on rotation #4679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
avelad
reviewed
Nov 10, 2022
|
Incremental code coverage: 12.82% |
joeyparrish
requested changes
Nov 10, 2022
joeyparrish
requested changes
Nov 10, 2022
joeyparrish
added
the
status: waiting on response
ocipap
requested review from
joeyparrish and
avelad
and removed request for
theodab,
joeyparrish and
avelad
joeyparrish
removed
the
status: waiting on response
|
Thank you for the review. An error occurred when I tried to enter fullscreen before the user's interaction, so I added error handling. Thank you! |
joeyparrish
requested changes
Nov 14, 2022
joeyparrish
requested changes
Nov 17, 2022
joeyparrish
changed the title
theodab
previously approved these changes
Nov 29, 2022
|
There are too many errors in the application log, so I want to solve them as soon as possible. 😢 |
joeyparrish
requested changes
Dec 5, 2022
joeyparrish
approved these changes
Dec 5, 2022
joeyparrish
added a commit
that referenced
this pull request
Dec 8, 2022
This refactors and cleans up fullscreen functionality in the UI so that all triggers are consistent and work correctly on all platforms. See also #4669 Co-authored-by: Joey Parrish <[email protected]>
joeyparrish
added a commit
that referenced
this pull request
Dec 8, 2022
This refactors and cleans up fullscreen functionality in the UI so that all triggers are consistent and work correctly on all platforms. See also #4669 Co-authored-by: Joey Parrish <[email protected]>
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors and cleans up fullscreen functionality in the UI so that all triggers are consistent and work correctly on all platforms.
See also #4669