Prefer unprefixed EME for Safari

[avelad]

I would like that as this is very old, the support for the newest api can be investigated.
https://github.com/google/shaka-player/blob/master/lib/polyfill/patchedmediakeys_apple.js#L36-L44

[TheModMaker]

It looks like the latest Safari does support the modern requestMediaKeySystemAccess and does support cenc; so we may be able to use that now.

[joeyparrish]

@avelad, I found a commented out section at the top of lib/polyfill/patchedmediakeys_apple.js which is responsible.

I don't have immediate access to a Mac or an iOS device. If you can, would you please try the following patch and let us know if FairPlay is working correctly for you on desktop Safari and iOS? If so, we could easily enable this in our next release.

diff --git a/lib/polyfill/patchedmediakeys_apple.js b/lib/polyfill/patchedmediakeys_apple.js
index 98fd2e6d..885f1fc4 100644
--- a/lib/polyfill/patchedmediakeys_apple.js
+++ b/lib/polyfill/patchedmediakeys_apple.js
@@ -33,15 +33,12 @@ shaka.polyfill.PatchedMediaKeysApple = class {
       return;
     }
 
-    // TODO: Prefer unprefixed EME once we know how to use it.
-    // See: https://bugs.webkit.org/show_bug.cgi?id=197433
-    /*
     if (navigator.requestMediaKeySystemAccess &&
+        // eslint-disable-next-line no-restricted-syntax
         MediaKeySystemAccess.prototype.getConfiguration) {
-      // Prefixed EME is preferable.
+      // Unprefixed EME is preferable.
       return;
     }
-    */
 
     shaka.log.info('Using Apple-prefixed EME');
 

[avelad]

@joeyparrish I have tested and it works by making the following change:

diff --git a/lib/media/drm_engine.js b/lib/media/drm_engine.js
index 80219f08..c05d1b47 100644
--- a/lib/media/drm_engine.js
+++ b/lib/media/drm_engine.js
@@ -698,7 +698,7 @@ shaka.media.DrmEngine = class {
     // Create a config entry for each key system.
     for (const info of allDrmInfo) {
       const config = {
-        // Ignore initDataTypes.
+        initDataTypes: ['cenc'],
         audioCapabilities: [],
         videoCapabilities: [],
         distinctiveIdentifier: 'optional',
@@ -1544,6 +1544,7 @@ shaka.media.DrmEngine = class {
     ];
 
     const basicConfig = {
+      initDataTypes: ['cenc'],
       videoCapabilities: basicVideoCapabilities,
     };
     const offlineConfig = {
diff --git a/lib/polyfill/patchedmediakeys_apple.js b/lib/polyfill/patchedmediakeys_apple.js
index 98fd2e6d..885f1fc4 100644
--- a/lib/polyfill/patchedmediakeys_apple.js
+++ b/lib/polyfill/patchedmediakeys_apple.js
@@ -33,15 +33,12 @@ shaka.polyfill.PatchedMediaKeysApple = class {
       return;
     }
 
-    // TODO: Prefer unprefixed EME once we know how to use it.
-    // See: https://bugs.webkit.org/show_bug.cgi?id=197433
-    /*
     if (navigator.requestMediaKeySystemAccess &&
+        // eslint-disable-next-line no-restricted-syntax
         MediaKeySystemAccess.prototype.getConfiguration) {
-      // Prefixed EME is preferable.
+      // Unprefixed EME is preferable.
       return;
     }
-    */
 
     shaka.log.info('Using Apple-prefixed EME');
 

I have tested in Safari 14 on macOS 10.15.7 and on iOS 14.2

It is necessary to always pass the initDataTypes field in requestMediaKeySystemAccess or it does not work, but this raises questions for me because in HLS-TS we should use SNIF, but I have tried with CENC and it works ...

[avelad]

Note: in safari 12 is not working but it works in safari 14. I don’t have access to safari 13.

[avelad]

@joeyparrish Resolved with 6d76a13

[joeyparrish]

Good catch. Closing thanks to #2999.