Skip to content

Commit

Permalink
fix: Disable unprefixed EME on Safari
Browse files Browse the repository at this point in the history
@avelad reported that PR #3021 caused a regression.  Rather than
revert the entire thing, we are disabling one part of that change to
make it easier to re-enable once the issue is fixed.  We will also
reopen issue #2999 until this is resolved.

Change-Id: I65d93da903d90668bb19e5248658eb458e8bb5c4
  • Loading branch information
joeyparrish committed Jan 25, 2021
1 parent fe7c902 commit 66cdd44
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion lib/polyfill/patchedmediakeys_apple.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ goog.require('shaka.util.EventManager');
goog.require('shaka.util.FakeEvent');
goog.require('shaka.util.FakeEventTarget');
goog.require('shaka.util.MediaReadyState');
goog.require('shaka.util.Platform');
goog.require('shaka.util.PublicPromise');
goog.require('shaka.util.StringUtils');

Expand All @@ -34,6 +33,9 @@ shaka.polyfill.PatchedMediaKeysApple = class {
return;
}

/* Unprefixed EME disabled. See:
https://github.com/google/shaka-player/pull/3021#issuecomment-766999811
// Only tested in Safari 14.
const safariVersion = shaka.util.Platform.safariVersion();
if (navigator.requestMediaKeySystemAccess &&
Expand All @@ -43,6 +45,7 @@ shaka.polyfill.PatchedMediaKeysApple = class {
// Unprefixed EME is preferable.
return;
}
*/

shaka.log.info('Using Apple-prefixed EME');

Expand Down

0 comments on commit 66cdd44

Please sign in to comment.