-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detach/re-attach to the video element on client-side ads for devices that don't support multiple media elements #2792
Comments
Any updates on this? |
Related to #2792 This is useful because it allows you to implement the use of IMA on platforms that do not support multiple video elements. See #5543 (comment)
) Related to shaka-project#2792 This is useful because it allows you to implement the use of IMA on platforms that do not support multiple video elements. See shaka-project#5543 (comment)
While implementing this logic on our end while waiting for this to be provided within Shaka, we faced an issue where track IDs upon a detach/attach flow would change and get incremented, leading to our comparison to re-select the previous selected text track to be broken. It would be nice to keep that in mind or allow a way to reset that state of IDs when re-attaching the player with the same manifest after an ad. |
I plan to implement this as soon as the Preload API is working correctly for unload |
With the following code implemented on the application side it is possible to support it: Using
|
Some device types don't support multiple video elements on the page and CS IMA has to reuse the same video element to show ads. (Tizen, WebOS)
For this scenario, we need to detach from the
<video>
and re-attach after the ads has finished playing.IMA has an isCustomPlaybackUsed method that we can call to check if the media element is gonna be reused (true if the method returns true :)).
We can call it when we get a content pause is requested by the SDK, and detach from the element if need be.
We'll need to save
video.currentTime
to be able to resume playback once the ads are done playing.The text was updated successfully, but these errors were encountered: