Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filterCharacterInfosByStyleTypeをstoreでも使うようにする #2

Conversation

y-chan
Copy link

@y-chan y-chan commented Jan 30, 2024

内容

題の通りです。
加えて、当該関数をstore/utilityに移動しています。

関連 Issue

Copy link
Owner

@sevenc-nanashi sevenc-nanashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです、ありがとうございます!

@sevenc-nanashi sevenc-nanashi merged commit a48c2cc into sevenc-nanashi:fix/empty-screen-without-engine-launched Jan 30, 2024
9 checks passed
sevenc-nanashi added a commit that referenced this pull request Jan 31, 2024
* Fix: エンジンが起動していないと画面が真っ白になるのを修正

* Fix: 型周りを修正

Co-Authored-By: y-chan <[email protected]>

* Fix: talk周りのハンドリングを修正

Co-Authored-By: y-chan <[email protected]>

* Add: テストを追加

* Fix: speakerUuidのインクリメントを修正

* `filterCharacterInfosByStyleType`をstoreでも使うようにする (#2)

* Add: コメントを追加

Co-authored-by: Hiroshiba <[email protected]>

* Refactor: filterCharacterInfosByStyleTypeのテストを整理

* Code: コードのスタイルを修正

* テストコード削減

* ドキュメント調整

---------

Co-authored-by: y-chan <[email protected]>
Co-authored-by: Yuto Ashida <[email protected]>
Co-authored-by: Hiroshiba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants