Red flicker fix/workaround #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@glennw try appears green (minus some sporadic errors unrelated to WR) |
|
Wow, that's an unfortunate bug :( Are there any comments you could add to that workaround bool with links to further information (I guess the bugzilla bug, or is there anything known on the angle bug list etc?). @bors-servo r+ |
|
📌 Commit 94250b3 has been approved by |
|
There is no simplified use-case yet, and no associated Angle issue. I'll make sure to correct the comment when we know more... |
bors-servo
pushed a commit
that referenced
this pull request
Jan 10, 2018
Red flicker fix/workaround Addresses https://bugzilla.mozilla.org/show_bug.cgi?id=1421696 ~~TODO:~~ gecko try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=27240e664f521285aa3d3ae76fce18886eba46c1&selectedJob=155374418 PR contains 3 things: 1. extensive validation of the render target list state with assertions. Note: none of those were triggered by the bug, but it's good to have them anyway for the future. 2. fixed reset to the previous FBO in `update_texture_storage` (this may fix some other issues, technically) 3. `WORK_AROUND_TEX_IMAGE ` fix, which resets a render target before trying to re-initialize it <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2280) <!-- Reviewable:end -->
|
💔 Test failed - status-travis |
|
OSX Travis is having a moment... |
bors-servo
pushed a commit
that referenced
this pull request
Jan 11, 2018
Red flicker fix/workaround Addresses https://bugzilla.mozilla.org/show_bug.cgi?id=1421696 ~~TODO:~~ gecko try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=27240e664f521285aa3d3ae76fce18886eba46c1&selectedJob=155374418 PR contains 3 things: 1. extensive validation of the render target list state with assertions. Note: none of those were triggered by the bug, but it's good to have them anyway for the future. 2. fixed reset to the previous FBO in `update_texture_storage` (this may fix some other issues, technically) 3. `WORK_AROUND_TEX_IMAGE ` fix, which resets a render target before trying to re-initialize it <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2280) <!-- Reviewable:end -->
|
@bors-servo r+ force retry |
nical
reviewed
Jan 11, 2018
| // Apparently, in some cases calling `glTexImage3D` with | ||
| // similar parameters that the texture already has confuses | ||
| // Angle when running with optimizations. | ||
| const WORK_AROUND_TEX_IMAGE: bool = cfg!(windows); |
There was a problem hiding this comment.
|
💥 Test timed out |
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Jan 11, 2018
Red flicker fix/workaround Addresses https://bugzilla.mozilla.org/show_bug.cgi?id=1421696 ~~TODO:~~ gecko try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=27240e664f521285aa3d3ae76fce18886eba46c1&selectedJob=155374418 PR contains 3 things: 1. extensive validation of the render target list state with assertions. Note: none of those were triggered by the bug, but it's good to have them anyway for the future. 2. fixed reset to the previous FBO in `update_texture_storage` (this may fix some other issues, technically) 3. `WORK_AROUND_TEX_IMAGE ` fix, which resets a render target before trying to re-initialize it <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2280) <!-- Reviewable:end -->
|
💔 Test failed - status-travis |
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Jan 13, 2018
Red flicker fix/workaround Addresses https://bugzilla.mozilla.org/show_bug.cgi?id=1421696 ~~TODO:~~ gecko try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=27240e664f521285aa3d3ae76fce18886eba46c1&selectedJob=155374418 PR contains 3 things: 1. extensive validation of the render target list state with assertions. Note: none of those were triggered by the bug, but it's good to have them anyway for the future. 2. fixed reset to the previous FBO in `update_texture_storage` (this may fix some other issues, technically) 3. `WORK_AROUND_TEX_IMAGE ` fix, which resets a render target before trying to re-initialize it <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2280) <!-- Reviewable:end -->
|
💔 Test failed - status-travis |
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Jan 13, 2018
Red flicker fix/workaround Addresses https://bugzilla.mozilla.org/show_bug.cgi?id=1421696 ~~TODO:~~ gecko try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=27240e664f521285aa3d3ae76fce18886eba46c1&selectedJob=155374418 PR contains 3 things: 1. extensive validation of the render target list state with assertions. Note: none of those were triggered by the bug, but it's good to have them anyway for the future. 2. fixed reset to the previous FBO in `update_texture_storage` (this may fix some other issues, technically) 3. `WORK_AROUND_TEX_IMAGE ` fix, which resets a render target before trying to re-initialize it <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2280) <!-- Reviewable:end -->
|
💔 Test failed - status-travis |
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
Jan 14, 2018
Red flicker fix/workaround Addresses https://bugzilla.mozilla.org/show_bug.cgi?id=1421696 ~~TODO:~~ gecko try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=27240e664f521285aa3d3ae76fce18886eba46c1&selectedJob=155374418 PR contains 3 things: 1. extensive validation of the render target list state with assertions. Note: none of those were triggered by the bug, but it's good to have them anyway for the future. 2. fixed reset to the previous FBO in `update_texture_storage` (this may fix some other issues, technically) 3. `WORK_AROUND_TEX_IMAGE ` fix, which resets a render target before trying to re-initialize it <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/2280) <!-- Reviewable:end -->
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://bugzilla.mozilla.org/show_bug.cgi?id=1421696
TODO:gecko try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=27240e664f521285aa3d3ae76fce18886eba46c1&selectedJob=155374418PR contains 3 things:
update_texture_storage(this may fix some other issues, technically)WORK_AROUND_TEX_IMAGEfix, which resets a render target before trying to re-initialize itThis change is