Add no_std support
#58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the matches crate, to actually be used on no_std targets, this requires either: - SimonSapin/rust-std-candidates#23 - That we bump the MSRV to 1.42.0 - That we change usage of the matches! macro
Shouldn't change the MSRV guarantee (tested on Rust 1.36.0).
Manishearth
approved these changes
Aug 12, 2021
|
Thanks! |
This was referenced Aug 13, 2021
Merged
mbrubeck
added a commit
to mbrubeck/unicode-bidi
that referenced
this pull request
Aug 14, 2021
This changed in servo#58.
mbrubeck
added a commit
to mbrubeck/unicode-bidi
that referenced
this pull request
Aug 14, 2021
This changed in servo#58.
Merged
mbrubeck
added a commit
to mbrubeck/unicode-bidi
that referenced
this pull request
Aug 14, 2021
This changed in servo#58.
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the matches crate, to actually be used on
no_stdtargets, this requires either:matchescrateno_stdcompatible SimonSapin/rust-std-candidates#23matches!macroI opted for the last option here, but feel free to only take the first commit (which still compiles fine even though the subcrate isn't marked
no_std, but downstream users will just get an error that they tried to link to std).