This repository has been archived by the owner on Jan 21, 2023. It is now read-only.
Make matches crate no_std compatible
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wanted to make the [`url`](https://github.com/servo/rust-url) crate `no_std` compatible, but since their MSRV is 1.36, they still use this crate, and hence is blocked here. Another option is to not do this and just wait until `url` updates their MSRV, or remove usage of the `matches!` macro from `url`.
|
Presumably you’ll want this on crates.io, so please also increment the version number to 0.1.9 in this PR. |
|
Alright, done! |
madsmtm
added a commit
to madsmtm/rust-url
that referenced
this pull request
Aug 13, 2021
See SimonSapin/rust-std-candidates#23 for the `matches` version bump.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to make the
urlcrateno_stdcompatible, but since their MSRV is 1.36, they still use this crate, and hence is blocked here.Another option is to not do this and just wait until
urlbumps their MSRV, or remove usage of thematches!macro fromurl.