Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support local errors with NPM 7 workspaces #782

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Support local errors with NPM 7 workspaces #782

merged 1 commit into from
Apr 12, 2021

Conversation

mikejpeters
Copy link
Contributor

@mikejpeters mikejpeters commented Apr 11, 2021

What did you implement:

Closes #781

How did you implement it:

When parsing npm ls stderr, ignore npm ERR! code ELSPROBLEMS and then all lines after the opening { (start of JSON and error summary).

How can we verify it:

I added a new test.

It should also resolve the issue demonstrated at this minimum example repo: boundstate/serverless-webpack-npm-7-example

Todos:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@j0k3r j0k3r changed the title Support npm 7 Support local errors with NPM 7 workspaces Apr 12, 2021
Copy link
Member

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me 👍

@j0k3r j0k3r added this to the 5.4.2 milestone Apr 12, 2021
@j0k3r
Copy link
Member

j0k3r commented Apr 12, 2021

Could you rebase against the master? Thanks

@j0k3r j0k3r added the awaiting reply Awaiting for a reply from the OP label Apr 12, 2021
@mikejpeters
Copy link
Contributor Author

Done

@j0k3r j0k3r removed the awaiting reply Awaiting for a reply from the OP label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm ls errors when using npm 7 workspaces
2 participants