Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore npm v7+ err ELSPROBLEMS #289

Conversation

mishabruml
Copy link
Contributor

@mishabruml mishabruml commented Mar 4, 2022

fixes #288
cribbed from serverless-heaven/serverless-webpack#782
simplified ignored error checking (removed ramda reduce in favour of ES5+ native Array.every()

@samchungy
Copy link
Collaborator

Thanks a bunch for raising a PR! 🙇‍♂️🙏 I'll take a looksie tomorrow morning! 😴

@samchungy samchungy self-requested a review March 4, 2022 11:31
samchungy
samchungy previously approved these changes Mar 5, 2022
Copy link
Collaborator

@samchungy samchungy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 thank you for your PR 😄

@samchungy samchungy changed the title fix: fixes #288 by ignoring npm err ELSPROBLEMS fix: ignore npm v7+ err ELSPROBLEMS Mar 5, 2022
@samchungy samchungy merged commit a2516d7 into floydspace:master Mar 13, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.26.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spontaneous Error: npm ls -json -prod -long -all failed with code 1 when running serverless deploy or package
2 participants