-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable colors for non-interactive output #481
Disable colors for non-interactive output #481
Conversation
40eb8d6
to
720b17b
Compare
@HyperBrain Can you look at this? Would help our Jenkins build from looking awful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps I'm missing something, but it doesn't seem like the tty
package is in the project's package.json
?
Disregard 😄
@hassankhan Can you help get this merged? |
@c0d3d Unfortunately I don't have write access to the repo, I would love to see this PR merged for the same reason 👍 @HyperBrain is there anything I can do to help get the PR merged in? 😄 |
@hassankhan I just invited you to the serverless-webpack-team. You should have write access as soon as you confirm the request ;-) |
Thanks for the invite @HyperBrain 😄 If there's no other issue with the PR, is it cool to go ahead and merge it? Or is there any other process I should be following aside from code-review + passing tests? |
No, that should be ok. However, it is important to have the milestone set
properly on the PR and the issue, so that I can create a proper changelog
for the next release
…On Sun, Apr 7, 2019 at 7:22 PM Hassan Khan ***@***.***> wrote:
Thanks for the invite @HyperBrain <https://github.com/HyperBrain> 😄! If
there's no other issue with the PR, is it cool to go ahead and merge it? Or
is there any other process I should be following aside from code-review +
passing tests?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#481 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFRM3nCMY8vJVqC9fXcm4F6QxozHM1HBks5veilVgaJpZM4aadMA>
.
|
Thanks for creating the PR @c0d3d, should be released in v5.3.0 👍 |
…-interactive Disable colors for non-interactive output
What did you implement:
Closes #480
How did you implement it:
Check if stdout is a tty when deciding to use colors or not.
How can we verify it:
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO