Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default color output should depend on TTY #480

Closed
c0d3d opened this issue Jan 30, 2019 · 3 comments · Fixed by #481
Closed

Default color output should depend on TTY #480

c0d3d opened this issue Jan 30, 2019 · 3 comments · Fixed by #481
Milestone

Comments

@c0d3d
Copy link
Contributor

c0d3d commented Jan 30, 2019

This is a Feature Proposal

Description

When piping the default webpack output into a file (or when using CI/CD tool without shell color escape support), color escapes are added. The plugin should first check if the output is a tty before writing colors (this is a more sensible default IMO). It can still be overridden explicitly, but by default the plugin should decide if the output supports colors before writing them.

Additional Data

  • Serverless-Webpack Version you're using: 5.2.0
  • Webpack version you're using: 4.16.4
  • Serverless Framework Version you're using: 1.30.0
  • Operating System: OSX
@c0d3d
Copy link
Contributor Author

c0d3d commented Feb 6, 2019

@HyperBrain, can you take a look at this?

@HyperBrain
Copy link
Member

@c0d3d I will check

@HyperBrain
Copy link
Member

Released with 5.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants