Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commonjs2 is the one that nodejs is using #450

Merged
merged 1 commit into from
Apr 7, 2019
Merged

commonjs2 is the one that nodejs is using #450

merged 1 commit into from
Apr 7, 2019

Conversation

stevemao
Copy link
Contributor

@stevemao stevemao commented Sep 26, 2018 •
edited
Loading

See webpack/webpack#1114

Is this ready for review?: YES
Is it a breaking change?: NOT for most users. since this plugin is for nodejs only

@stevemao
Copy link
Contributor Author

I also think that all examples should use commonjs2. There's actually no environment that's using commonjs

@HyperBrain
Copy link
Member

Hi @stevemao ,
thanks for the PR. I think you are right, and we should be safe to change the default to commonjs2.
Can you also adapt the unit tests, because they are now failing (they still check for commonjs).
... and feel free to change the examples in this PR too

@stevemao
Copy link
Contributor Author

@HyperBrain done :)

HyperBrain
HyperBrain approved these changes Apr 7, 2019
View reviewed changes
Copy link
Member

@HyperBrain HyperBrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevemao Sorry for the VERY late response.

@HyperBrain HyperBrain added this to the 5.2.1 milestone Apr 7, 2019
@HyperBrain HyperBrain merged commit 9f4500e into serverless-heaven:master Apr 7, 2019
@hassankhan hassankhan mentioned this pull request Jun 2, 2019
Closed
HyperBrain pushed a commit that referenced this pull request Jun 6, 2019
Revert "Merge pull request #450 from stevemao/patch-1"
41dd875 
This reverts commit 9f4500e, reversing
changes made to 557170b.
Fixes #505
jamesmbourne pushed a commit to jamesmbourne/serverless-webpack that referenced this pull request Oct 15, 2019
@HyperBrain
Merge pull request serverless-heaven#450 from stevemao/patch-1
1b44bf4 
commonjs2 is the one that nodejs is using
jamesmbourne pushed a commit to jamesmbourne/serverless-webpack that referenced this pull request Oct 15, 2019
Revert "Merge pull request serverless-heaven#450 from stevemao/patch-1"
967b4fc 
This reverts commit 9f4500e, reversing
changes made to 557170b.
Fixes serverless-heaven#505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HyperBrain HyperBrain HyperBrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@stevemao @HyperBrain