5.3.0: Handler 'handler' missing on module #505

joebernard · 2019-05-22T02:54:17Z

This is a (Bug Report / Feature Proposal)

Bug Report

Description

For bug reports:

What went wrong?
Upgrading from 5.2.0 to 5.3.0 causes Lambda to not recognize exports.handler within the webpack generated Lambda function. Upon upgrading and running sls deploy, a Lambda function with an import statement will return the following error:

Handler 'handler' missing on module

Upon rolling back to 5.2.0 and another sls deploy, the handler is recognized again.

What did you expect should have happened?
The packager should not obscure exports.handler.
What was the config you used?

package.json

{
  "name": "app",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "private": true,
  "workspaces": [
    "src/lib/*"
  ],
  "sideEffects": false,
  "author": "",
  "license": "ISC",
  "devDependencies": {
    "@babel/core": "^7.4.3",
    "@babel/preset-env": "^7.4.3",
    "aws-sdk": "^2.437.0",
    "babel-core": "7.0.0-bridge.0",
    "babel-eslint": "^10.0.1",
    "babel-loader": "^8.0.4",
    "babel-plugin-source-map-support": "^2.0.1",
    "babel-polyfill": "^6.26.0",
    "eslint": "^5.16.0",
    "eslint-config-airbnb": "^17.1.0",
    "eslint-config-prettier": "^4.1.0",
    "eslint-plugin-import": "^2.17.1",
    "eslint-plugin-jsx-a11y": "^6.2.1",
    "eslint-plugin-prettier": "^3.0.1",
    "eslint-plugin-react": "^7.12.4",
    "prettier": "^1.17.0",
    "progress-bar-webpack-plugin": "^1.12.1",
    "serverless-plugin-split-stacks": "^1.7.2",
    "serverless-webpack": "^5.2.0",
    "terser-webpack-plugin": "^1.2.3",
    "webpack": "^4.30.0",
    "webpack-cli": "^3.2.3"
  },
  "dependencies": {
    "crypto-secure-random-digit": "^1.0.7",
    "serverless-appsync-plugin": "^1.1.0",
    "serverless-plugin-aws-alerts": "^1.2.4",
    "source-map-support": "^0.5.12"
  }
}

webpack.config.js

const path = require("path");
const webpack = require("webpack");
const slsw = require("serverless-webpack");
const TerserPlugin = require("terser-webpack-plugin");
const ProgressBarPlugin = require("progress-bar-webpack-plugin");

const handler = (percentage, message, ...args) => {
  // e.g. Output each progress message directly to the console:
  console.info(percentage, message, ...args);
};

module.exports = {
  mode: "development",
  entry: slsw.lib.entries,
  target: "node",
  devtool: "none",
  externals: [
    {
      "aws-sdk": "commonjs aws-sdk",
      bufferutil: "commonjs bufferutil",
      "utf-8-validate": "commonjs utf-8-validate"
    }
  ],
  plugins: [
    new ProgressBarPlugin(),
    new webpack.IgnorePlugin(/^\.\/locale$/, /moment$/)
  ],
  optimization: {
    minimizer: [new TerserPlugin({ parallel: true, sourceMap: false })], // sourceMap: true
    minimize: false,
    usedExports: true
  },
  performance: {
    hints: false
  },
  stats: {
    maxModules: Infinity,
    optimizationBailout: false
  },
  module: {
    rules: [
      {
        test: /\.js$/,
        loader: "babel-loader",
        include: path.resolve(__dirname, "src/services"),
        sideEffects: false,
        options: {
          babelrc: false,
          presets: [
            [
              "@babel/preset-env",
              {
                targets: {
                  node: "8.10"
                },
                shippedProposals: true,
                modules: false,
                debug: false
              }
            ]
          ]
        }
      }
    ]
  }
};

from serverless.json

webpack:
    packager: "yarn"
    webpackConfig: "./webpack.config.js"

What stacktrace or error message from your provider did you see?

Handler 'handler' missing on module

Additional Data

The problem only seems to arise with lambda functions using import. If the function does not contain an import, it seems to be understood by Lambda (it finds the handler). I created a simple test function and packaged two versions of it using 5.3.0. One has an import, the other does not. The imported file is also very simplistic and just contains a console.log(). Here is a selection of the generated output from each:

without import:

function(module, __webpack_exports__, __webpack_require__) {
        "use strict";
        __webpack_require__.r(__webpack_exports__);
        /* harmony import */ var test__WEBPACK_IMPORTED_MODULE_0__ = __webpack_require__(
          /*! test */ "./src/lib/test/index.js"
        );
        exports.handler = async event => {
          console.log(JSON.stringify(event)); // const { userId } = event;
        };

        /***/
      }

with import

(function(module, __webpack_exports__, __webpack_require__) {

"use strict";
__webpack_require__.r(__webpack_exports__);
/* harmony import */ var test__WEBPACK_IMPORTED_MODULE_0__ = __webpack_require__(/*! test */ "./src/lib/test/index.js");

exports.handler = async event => {
  console.log(JSON.stringify(event)); // const { userId } = event;

};

/***/ })

When the file contains an import, the function containing exports.handler is wrapped in parenthesis. Perhaps this is causing Lambda to not see handler somehow. This was the only difference I could find between the generated files.

Serverless-Webpack Version you're using: 5.3.0
Webpack version you're using: ^4.30.0
Serverless Framework Version you're using: 1.4.3
Operating System: MacOS 10.14.5
Stack Trace (if available):

The text was updated successfully, but these errors were encountered:

HyperBrain · 2019-05-23T20:10:43Z

@serverless-heaven/serverless-webpack-team @serverless-heaven/serverless-webpack-contributors Any idea what could have caused this regression?

Hugoo · 2019-06-01T12:13:16Z

Same problem here, I'm also using import XXX from XXX in my functions.

webpack.config.js

const slsw = require('serverless-webpack');

module.exports = {
  entry: slsw.lib.entries,
  target: 'node',
  devtool: 'source-map',
  mode: 'production',
  optimization: {
    minimize: false
  },
  performance: {
    hints: false
  },
  externals: [
    // Those externals modules are either to heavy or can't be compilated with Webpack. They are in a separate layer
    {
      'aws-sdk': 'aws-sdk', // Included by default in Lambda execution environment
      pg: 'pg',
      'pg-hstore': 'pg-hstore',
      sequelize: 'sequelize'
    }
  ]
};

HyperBrain · 2019-06-01T17:09:42Z

@Hugoo @joebernard Can anyone of you provide a sample setup that can be used to reproduce (and investigate) the issue?

Hugoo · 2019-06-02T13:23:53Z

@HyperBrain , sure, I uploaded a simple repo here :

https://github.com/Hugoo/sls-webpack-bug

I didn't try it on AWS but by using sls offline I can see the error.

Please let me know if you want more details.

hassankhan · 2019-06-02T20:29:17Z

@HyperBrain sorry for the delayed response, not had a chance to upgrade production projects to v5.3.0 yet.

@Hugoo thanks for uploading the sample repo

hassankhan · 2019-06-02T21:20:55Z

Hi all, I've gone through the commit log using @Hugoo's sample repo and I've narrowed it down to PR #450. I think the quickest fix would be to revert the commit, thoughts?

HyperBrain · 2019-06-03T12:06:31Z

Fully agree! Lets revert the commit and I'll release the version as 5.3.1. I just checked that master contains only bug fixes right now, so merging the revert with a subsequent release will be fine.

…

On Sun, Jun 2, 2019 at 11:21 PM Hassan Khan ***@***.***> wrote: Hi all, I've gone through the commit log using @Hugoo <https://github.com/Hugoo>'s sample repo and I've narrowed it down to PR #450 <#450>. I think the quickest fix would be to revert the commit, thoughts? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#505?email_source=notifications&email_token=ABKEZXWQP2JSNLHYE7ZYADDPYQ2TRA5CNFSM4HOQHNPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWX6ICI#issuecomment-498066441>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABKEZXQFLRY6QETGJAAAXZLPYQ2TRANCNFSM4HOQHNPA> .

HyperBrain · 2019-06-06T22:19:38Z

@Hugoo @joebernard @hassankhan I pushed a revert commit of #450 to master.
Can you please verify with
"serverless-webpack": "github:serverless-heaven/serverless-webpack#master"
and give feedback if it works?
I will then do a bugfix release (5.3.1) tomorrow.
Thanks

stevemao · 2019-06-07T02:58:18Z

Very strange. Would be good if @TheLarkInn could share some insights. Thanks

HyperBrain · 2019-06-07T07:30:08Z

Yes, but for a quick fix we'll go with the revert for 5.3.1 and we should analyze what exactly happens. It even might be related to specific versions of webpack or babel. However, we can get it in for a future version (probably 5.4.0) as soon as we can add the change properly without side effects.

…

On Fri, Jun 7, 2019 at 4:58 AM Steve Mao ***@***.***> wrote: Very strange. Would be good if @TheLarkInn <https://github.com/TheLarkInn> could share some insights. Thanks — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#505?email_source=notifications&email_token=ABKEZXQS66QNPV36XDWWW3DPZHFEXA5CNFSM4HOQHNPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXEW5YY#issuecomment-499740387>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABKEZXWYTB5PJSXP3CSNGVTPZHFEXANCNFSM4HOQHNPA> .

Hugoo · 2019-06-07T07:46:24Z

github:serverless-heaven/serverless-webpack#master

It works for me!

joebernard · 2019-06-07T15:08:06Z

This looks good to me.

HyperBrain · 2019-06-07T19:35:49Z

Released as 5.3.1

Hugoo · 2019-06-08T09:15:50Z

Release 5.3.1 solved this problem for me.

Thank you !

This reverts commit 9f4500e, reversing changes made to 557170b. Fixes serverless-heaven#505

HyperBrain added the bug label May 23, 2019

HyperBrain mentioned this issue Jun 2, 2019

default webpackConfig.node should be false #502

Merged

7 tasks

hassankhan added this to the 5.3.1 milestone Jun 2, 2019

hassankhan mentioned this issue Jun 2, 2019

V3: Unable to import module 'handler': Error #43

Closed

HyperBrain closed this as completed in 41dd875 Jun 6, 2019

HyperBrain mentioned this issue Jun 6, 2019

Prepare release - 5.3.1 #512

Merged

afreix mentioned this issue Sep 5, 2019

Custom authorizer handler cannot be resolved dherault/serverless-offline#802

Closed

jamesmbourne pushed a commit to jamesmbourne/serverless-webpack that referenced this issue Oct 15, 2019

Revert "Merge pull request serverless-heaven#450 from stevemao/patch-1"

967b4fc

This reverts commit 9f4500e, reversing changes made to 557170b. Fixes serverless-heaven#505

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

5.3.0: Handler 'handler' missing on module #505

5.3.0: Handler 'handler' missing on module #505

joebernard commented May 22, 2019

HyperBrain commented May 23, 2019

Hugoo commented Jun 1, 2019

HyperBrain commented Jun 1, 2019

Hugoo commented Jun 2, 2019

hassankhan commented Jun 2, 2019

hassankhan commented Jun 2, 2019

HyperBrain commented Jun 3, 2019 via email

HyperBrain commented Jun 6, 2019

stevemao commented Jun 7, 2019

HyperBrain commented Jun 7, 2019 via email

Hugoo commented Jun 7, 2019

joebernard commented Jun 7, 2019

HyperBrain commented Jun 7, 2019

Hugoo commented Jun 8, 2019

5.3.0: Handler 'handler' missing on module #505

5.3.0: Handler 'handler' missing on module #505

Comments

joebernard commented May 22, 2019

This is a (Bug Report / Feature Proposal)

Description

Additional Data

HyperBrain commented May 23, 2019

Hugoo commented Jun 1, 2019

HyperBrain commented Jun 1, 2019

Hugoo commented Jun 2, 2019

hassankhan commented Jun 2, 2019

hassankhan commented Jun 2, 2019

HyperBrain commented Jun 3, 2019 via email

HyperBrain commented Jun 6, 2019

stevemao commented Jun 7, 2019

HyperBrain commented Jun 7, 2019 via email

Hugoo commented Jun 7, 2019

joebernard commented Jun 7, 2019

HyperBrain commented Jun 7, 2019

Hugoo commented Jun 8, 2019