Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove range-v3 take and single #2968

Merged
merged 2 commits into from
May 3, 2022
Merged

Conversation

SGSSGene
Copy link
Contributor

This PR does two things:

  1. Remove ranges/v3/take.hpp by removing an obsolete unit test.
  2. Remove an obsolete include of ranges/v3/single.hpp which wasn't used.

This is part of seqan/product_backlog#124
-A life Without Range-v3-

This is the last place where ranges::view::take is being used.
The test checks if std::views::take is combinable with
ranges::view::take. If this test fails there is really nothing we can
do since the code is far outside of our range.

-A life Without Range-v3-
This removes the include range/v3/single.hpp. It was never required/used
by the file. On our way to reduce dependency onto range-v3 this include
has to go!

-A life Without Range-v3-
@vercel
Copy link

vercel bot commented Apr 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
seqan3 ✅ Ready (Inspect) Visit Preview Apr 26, 2022 at 0:37AM (UTC)

@SGSSGene SGSSGene requested review from a team and Irallia and removed request for a team April 26, 2022 12:34
@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #2968 (da1a7aa) into master (b4984bc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2968   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files         267      267           
  Lines       11511    11511           
=======================================
  Hits        11307    11307           
  Misses        204      204           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5c63f9...da1a7aa. Read the comment docs.

Copy link
Contributor

@Irallia Irallia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@Irallia Irallia requested review from a team and eseiler and removed request for a team April 26, 2022 16:24
@eseiler eseiler merged commit e66cf54 into seqan:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants