Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alignment] Deprecate seqan3::alignment_coordinate #2602

Merged
merged 8 commits into from
May 6, 2021

Conversation

marehr
Copy link
Member

@marehr marehr commented May 4, 2021

@marehr marehr requested review from a team and Irallia and removed request for a team May 4, 2021 18:52
@vercel
Copy link

vercel bot commented May 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/F9BemzmHHzzFaNipwMKKak7cpwWc
✅ Preview: https://seqan3-git-fork-marehr-alignmentcoordinate-seqan.vercel.app

@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #2602 (2d1154c) into master (7c8f5c3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2602   +/-   ##
=======================================
  Coverage   98.27%   98.27%           
=======================================
  Files         272      272           
  Lines       10789    10795    +6     
=======================================
+ Hits        10603    10609    +6     
  Misses        186      186           
Impacted Files Coverage Δ
...ment/matrix/detail/alignment_trace_matrix_base.hpp 100.00% <ø> (ø)
...ment/matrix/detail/alignment_trace_matrix_full.hpp 100.00% <ø> (ø)
...trix/detail/alignment_trace_matrix_full_banded.hpp 97.87% <ø> (ø)
...qan3/alignment/matrix/detail/matrix_coordinate.hpp 100.00% <ø> (ø)
...matrix/detail/advanceable_alignment_coordinate.hpp 100.00% <100.00%> (ø)
.../seqan3/alignment/pairwise/alignment_algorithm.hpp 100.00% <100.00%> (ø)
...qan3/alignment/pairwise/edit_distance_unbanded.hpp 99.29% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c8f5c3...2d1154c. Read the comment docs.

Copy link
Contributor

@Irallia Irallia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM!
The only thing missing is the lexicographical order in the all.hpp

include/seqan3/alignment/matrix/all.hpp Outdated Show resolved Hide resolved
@marehr marehr requested a review from Irallia May 5, 2021 15:47
@Irallia Irallia requested review from a team and eseiler and removed request for a team May 5, 2021 16:08
Copy link
Member

@eseiler eseiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things regarding deprecation.
Also, a changelog entry is missing. (or is there already one?)

include/seqan3/alignment/matrix/all.hpp Outdated Show resolved Hide resolved
test/unit/alignment/matrix/alignment_coordinate_test.cpp Outdated Show resolved Hide resolved
include/seqan3/alignment/matrix/alignment_coordinate.hpp Outdated Show resolved Hide resolved
@marehr marehr requested a review from eseiler May 6, 2021 10:06
@marehr marehr force-pushed the alignment_coordinate branch from 845ff1c to 199c10b Compare May 6, 2021 10:14
@marehr marehr force-pushed the alignment_coordinate branch from 199c10b to 2d1154c Compare May 6, 2021 10:38
@marehr marehr merged commit 6e0da66 into seqan:master May 6, 2021
@marehr marehr deleted the alignment_coordinate branch May 6, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Alignment] Deprecate seqan3::alignment_coordinate
3 participants