-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alignment] Deprecate seqan3::alignment_coordinate
#2602
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/seqan/seqan3/F9BemzmHHzzFaNipwMKKak7cpwWc |
Codecov Report
@@ Coverage Diff @@
## master #2602 +/- ##
=======================================
Coverage 98.27% 98.27%
=======================================
Files 272 272
Lines 10789 10795 +6
=======================================
+ Hits 10603 10609 +6
Misses 186 186
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGFM!
The only thing missing is the lexicographical order in the all.hpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some things regarding deprecation.
Also, a changelog entry is missing. (or is there already one?)
…ail::advanceable_alignment_coordinate<>
845ff1c
to
199c10b
Compare
199c10b
to
2d1154c
Compare
resolves seqan/product_backlog#282