Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alignment] Deprecate seqan3::alignment_coordinate #282

Closed
5 tasks done
smehringer opened this issue Jan 18, 2021 · 2 comments · Fixed by seqan/seqan3#2602
Closed
5 tasks done

[Alignment] Deprecate seqan3::alignment_coordinate #282

smehringer opened this issue Jan 18, 2021 · 2 comments · Fixed by seqan/seqan3#2602
Assignees

Comments

@smehringer
Copy link
Member

smehringer commented Jan 18, 2021

Description

Discussed in #268 (comment)

The seqan3::alignment_result provides single functions for begin and end positions, so a public coordinate is not needed anymore.

Tasks

  • Add SEQAN3_DEPRECATED_310 macro to the seqan3::alignment_coordinate class
  • Add [DEPREACTED] in front of the brief message of seqan3::alignment_coordinate
  • Add the \deprecated doxygen tag to the class brief
  • Remove snippets used in the documentation
  • Check any mentions in the tutorials and remove them

Note: Do not delete the tests yet. This can be done if the entity is removed. Instead, wrap the (respective) tests and all other possible usage in

#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
  
#pragma GCC diagnostic pop
@SGSSGene
Copy link

Currently I am stuck with fixing alignment_fixture in test/unit/alignment/pairwise/fixture/alignment_fixture.hpp
It uses seqan3::alignment_coordinate and I don't know what I should replace it with.

@marehr
Copy link
Member

marehr commented May 4, 2021

I took over and finished this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants