-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] fix internal compiler error on gcc-7 #2430
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/seqan/seqan3/A9nQkG28QEm2eHtRUZKdJ9xj2Bx4 |
Codecov Report
@@ Coverage Diff @@
## master #2430 +/- ##
==========================================
- Coverage 98.24% 98.24% -0.01%
==========================================
Files 267 267
Lines 10917 10912 -5
==========================================
- Hits 10725 10720 -5
Misses 192 192
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some ideas and questions about the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation.
Changes in #2427 triggered an ICE (in Fact the same one that @MitraDarja had in #2337).
This is an attempt to fix this ICE once and for all by using an "easier" way of using is_valid_char at compile time.
Also part of seqan/product_backlog#124, since it throws away some meta-library functionality.