Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] fix internal compiler error on gcc-7 #2430

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

marehr
Copy link
Member

@marehr marehr commented Mar 5, 2021

Changes in #2427 triggered an ICE (in Fact the same one that @MitraDarja had in #2337).

This is an attempt to fix this ICE once and for all by using an "easier" way of using is_valid_char at compile time.

Also part of seqan/product_backlog#124, since it throws away some meta-library functionality.

@vercel
Copy link

vercel bot commented Mar 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/A9nQkG28QEm2eHtRUZKdJ9xj2Bx4
✅ Preview: https://seqan3-git-fork-marehr-fixicegcc7-seqan.vercel.app

@marehr marehr requested review from a team and Irallia and removed request for a team March 5, 2021 14:14
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #2430 (9bba93f) into master (08bab5d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2430      +/-   ##
==========================================
- Coverage   98.24%   98.24%   -0.01%     
==========================================
  Files         267      267              
  Lines       10917    10912       -5     
==========================================
- Hits        10725    10720       -5     
  Misses        192      192              
Impacted Files Coverage Δ
...ude/seqan3/alphabet/composite/alphabet_variant.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08bab5d...5d1bae8. Read the comment docs.

Copy link
Contributor

@Irallia Irallia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some ideas and questions about the tests.

@marehr marehr requested a review from Irallia March 5, 2021 15:04
Copy link
Contributor

@Irallia Irallia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation.

@marehr marehr requested a review from eseiler March 9, 2021 13:37
@eseiler eseiler merged commit 920cdcc into seqan:master Mar 9, 2021
@marehr marehr deleted the fix_ice_gcc7 branch March 17, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants