[MISC] Update range library #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marehr
requested review from
a team,
wvdtoorn,
eseiler,
simonsasse and
joergi-w
and removed request for
a team,
wvdtoorn,
eseiler and
simonsasse
joergi-w
requested changes
Apr 1, 2020
|
Current build failure was introduced in ericniebler/range-v3@6103268. |
Codecov Report
@@ Coverage Diff @@
## master #1702 +/- ##
=======================================
Coverage 97.68% 97.68%
=======================================
Files 238 238
Lines 9066 9066
=======================================
Hits 8856 8856
Misses 210 210 Continue to review full report at Codecov.
|
joergi-w
reviewed
Apr 4, 2020
This was referenced Apr 5, 2020
In this case the construction of (`views::persist | views::convert`) relied on some implicit conversion instead of using the target type directly.
In ericniebler/range-v3#1455 the range-v3 library harmonises range-v3 with C++20's `std::ranges`. One of these changes is the behaviour of `std::ranges::enable_view`. This change is needed for seqan#1680 that will simplify code regarding the `seqan3::gap_decorator`.
rrahn
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ericniebler/range-v3#1455 the range-v3 library
harmonises range-v3 with C++20's
std::ranges. One of these changes isthe behaviour of
std::ranges::enable_view.This change is needed for #1680 that will simplify code regarding the
seqan3::gap_decorator.